maxikrie commented on code in PR #18117: URL: https://github.com/apache/nuttx/pull/18117#discussion_r2722547809
########## arch/arm/src/nrf52/nrf52_tim_lowerhalf.c: ########## @@ -54,7 +54,7 @@ /* Maximum supported timeout */ -#define NRF52_TIMER_MAXTIMEOUT (NRF52_TIMER_MAX * (1000000 / NRF52_TIMER_PER)) +#define NRF52_TIMER_MAXTIMEOUT ((uint64_t)NRF52_TIMER_MAX * 1000000 / NRF52_TIMER_PER) Review Comment: I guess this is possible and I am not an expert on this, but it changes the type globally and forces 64-bit math everywhere it is used. I am not sure what is the best practice and when it is OK for macros to represent also a type. By embedding ll into the -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
