aviralgarg05 opened a new pull request, #18140: URL: https://github.com/apache/nuttx/pull/18140
## Summary * Recent changes in the networking stack require `IFF_RUNNING` for traffic processing. * The IMXRT ENET driver was missing the `netdev_carrier_on/off` calls to update this status. * This PR adds `netdev_carrier_on(dev)` in `imxrt_ifup_action` and `netdev_carrier_off(dev)` in `imxrt_ifdown`. * Fixes connectivity issues for all IMXRT boards using this driver. * Related Issue: <https://github.com/apache/nuttx/issues/18110> ## Impact * Is new feature added? NO * Impact on user? YES (restores networking functionality). * Impact on build? NO * Impact on hardware? YES (IMXRT ENET driver modified). * Impact on documentation? NO * Impact on security? NO * Impact on compatibility? YES (fixes regression). * Anything else to consider? Code style preserved via surgical insertion. ## Testing I confirm that changes are verified on local setup and works as intended: * Build Host: macOS 15.0.1 (Apple M2), Compiler: `arm-none-eabi-gcc (GCC) 15.2.0`. * Target: `imxrt1060-evk:netnsh` (Driver: `imxrt_enet.c`). * Style Check: `./tools/checkpatch.sh -f arch/arm/src/imxrt/imxrt_enet.c` passes with no errors. Testing logs (Compilation Verification): ```bash arm-none-eabi-gcc -c -march=armv7e-m -mtune=cortex-m7 -mfloat-abi=soft \ -isystem include -D__NuttX__ -D__KERNEL__ \ -I sched -I arch/arm/src/chip -I arch/arm/src/common -I arch/arm/src/armv7-m \ arch/arm/src/imxrt/imxrt_enet.c -o imxrt_enet.o ``` Result: Compilation successful. Style Verification Log: ```bash $ ./tools/checkpatch.sh -f arch/arm/src/imxrt/imxrt_enet.c ✔️ All checks pass. ``` ## PR verification Self-Check * [x] This PR introduces only one functional change. * [x] I have updated all required description fields above. * [x] My PR adheres to Contributing [Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md) and [Documentation](https://nuttx.apache.org/docs/latest/contributing/index.html) (git commit title and message, coding standard, etc). * [ ] My PR is still work in progress (not ready for review). * [x] My PR is ready for review and can be safely merged into a codebase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
