acassis commented on PR #18127: URL: https://github.com/apache/nuttx/pull/18127#issuecomment-3799708321
> > @Kaben123 thank you for adding a new feature to syslog. All new features need to be properly documented. Please update https://nuttx.apache.org/docs/latest/components/drivers/special/syslog.html#syslog > > Where and how these new IOCTLs will be called? Please provide some tool to control syslog? > > In the Linux kernel we have /proc/sys/kernel/printk_ratelimit to control kernel printk rate limit. For the journald we have /etc/systemd/journald.conf: > > ``` > > RateLimitIntervalSec=30s > > RateLimitBurst=1000 > > ``` > > > > > > > > > > > > > > > > > > > > > > > > We need to have something similar or at least a Kconfig to setup the default parameters > > There is no interface like /proc/sys/kernel/printk_ratelimit in Linux. Patches will be submitted later that implement something like printk_ratelimit. > Maybe it was removed, but that is something that existed on Linux: https://www.reddit.com/r/linuxquestions/comments/1iq73ef/remove_kernel_log_printk_rate_limits/ https://docs.kernel.org/admin-guide/sysctl/kernel.html#printk-ratelimit > The rl_ratelimit.interval defaults to 0, in which case ramlog does not make any effort to limit flow. Each ramlog instance supports individual rate limiting configuration. > > The documentation for the new RAMLOG rate limiting feature and IOCTLs has been added to the syslog driver documentation, including usage and a sample NSH command implementation (see "RAMLOG Rate Limiting" section). > > Please help review. Thanks! @acassis Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
