linguini1 commented on PR #18140: URL: https://github.com/apache/nuttx/pull/18140#issuecomment-3800668156
> @linguini1 This is an obvious fix for an obvious bug and probably all ethernet drivers need fix like this. Will you demand HW tests for all broken boards? Have you bothered to understand this change instead of blocking it? I understand that this is an "obvious fix", but PRs that get merged into NuttX without proper testing can have side-effects that aren't intended. I have seen PRs get approved without testing and subsequently fail CI builds. It has happened before and it will happen again. This PR is quite literally one day old, and there is a direct issue it is aiming to fix with a user who has access to the reference hardware, who reported the bug initially and who is capable of verifying whether or not this change solves his bug. I think that since this PR has not been tested, it is a good idea to have the reporter verify that his issue is actually fixed by the patch. No, I don't demand a hardware test for all broken boards. I think it would be good for the hardware to be tested by the user who encountered this bug. And for other PRs where I make similar requests, the expectation I have is that if a change is made to fix a bug, the author of the change should have some evidence that their change actually fixes the bug on the system they discovered the issue on. It does not need to be tested with all possible boards that it may touch, although the more the merrier. I don't mean to be hostile with my request, but these requirements were something we voted on. We can always revisit the discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
