hujun260 commented on code in PR #18199:
URL: https://github.com/apache/nuttx/pull/18199#discussion_r2734823310
##########
sched/semaphore/sem_clockwait.c:
##########
@@ -137,14 +137,14 @@ int nxsem_clockwait(FAR sem_t *sem, clockid_t clockid,
ret = nxsem_wait(sem);
+ leave_critical_section(flags);
Review Comment:
> BTW, have you considered the case where the semaphore is waited on by
other threads before wd_cancel is called, which would cause wd_cancel to
incorrectly cancel other pending events?
This won't happen. For other threads calling this, wd_start(&rtcb->waitdog
....)
rtcb is always this_task, so wd_cancel won't incorrectly cancel the watchdog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
