sebastianene07 commented on a change in pull request #1602:
URL: https://github.com/apache/incubator-nuttx/pull/1602#discussion_r478119730



##########
File path: arch/sim/src/Makefile
##########
@@ -92,6 +93,17 @@ ifeq ($(CONFIG_SPINLOCK),y)
   HOSTSRCS += up_testset.c
 endif
 
+ifeq ($(CONFIG_SIM_PREEMPTIBLE),y)
+  HOSTSRCS += up_ucontext.c
+  HOSTCFLAGS += -DCONFIG_SIM_PREEMPTIBLE=$(CONFIG_SIM_PREEMPTIBLE)
+ifeq ($(CONFIG_HOST_MACOS), y)
+  CFLAGS += -D_XOPEN_SOURCE -Wno-deprecated-declarations
+  HOSTCFLAGS += -D_XOPEN_SOURCE -Wno-deprecated-declarations
+  HOSTCFLAGS += -pthread

Review comment:
       I saw OSX requires it to link correctly otherwise I'll get an error

##########
File path: arch/sim/src/sim/up_blocktask.c
##########
@@ -82,7 +82,7 @@ void up_block_task(struct tcb_s *tcb, tstate_t task_state)
   DEBUGASSERT((tcb->task_state >= FIRST_READY_TO_RUN_STATE) &&
               (tcb->task_state <= LAST_READY_TO_RUN_STATE));
 
-  /* sinfo("Blocking TCB=%p\n", tcb); */
+  sinfo("Blocking TCB=%p %s\n", tcb, tcb->name);

Review comment:
       I removed it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to