xiaoxiang781216 commented on a change in pull request #1655:
URL: https://github.com/apache/incubator-nuttx/pull/1655#discussion_r478146729
##########
File path: arch/sim/src/sim/up_idle.c
##########
@@ -116,4 +116,8 @@ void up_idle(void)
up_timer_update();
#endif
+
+#ifdef CONFIG_SIM_HCISOCKET
+ bthcisock_read();
Review comment:
But if you look at the prototype:
```
int bthcisock_read(void);
```
it doesn't like the normal read function which accept the buffer and length
argument:
```
int bthcisock_host_read(int fd, uint8_t *type, void *buf, size_t len);
```
And in the implementation, it call bthcisock_host_read and bt_hci_receive
which convert the pull model(read) to the push model(receive).
So from both the prototype and implementation, read isn't a suitable name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
