linguini1 commented on PR #18235: URL: https://github.com/apache/nuttx/pull/18235#issuecomment-3818173232
> sorry, I used an AI-generated PR template; I'll update the PR description. This feature has been integrated and tested on our product. I can provide the ostest logs. Please format the ostest logs inside of a code-block so it is readable. Can you please provide the logs/test description for all of these cases as well? > Compilation successful with all warning flags > waitid() behavior unchanged for valid parameters > Error conditions properly handled and reported > All goto statements eliminated and replaced > Cyclomatic complexity reduced (waittcb extracted) > Parameter validation preserved and reorganized > Child status tracking unchanged > Signal handling unchanged (SIGCHLD semantics preserved) > Critical section protection timing unchanged > Cancellation point semantics maintained > Coverity HIS_metric_violation (CCM, HIS_GOTO) defects resolved > Code review completed - all logic paths tested > > Valid Child Wait (P_PID): Verify waitid() waits for specific child > Any Child Wait (P_ALL): Verify waitid() waits for any child > No Children: Verify ECHILD returned when no children exist > Already Exited Child: Verify quick return for already-exited child > WNOHANG Option: Verify non-blocking wait behavior > Signal Interruption: Verify correct handling of interrupted waits > Invalid ID Types: Verify ENOSYS returned for unsupported types > Child Status Tracking: Test with CONFIG_SCHED_CHILD_STATUS enabled/disabled > Concurrent Operations: Test multiple threads waiting on children > Error Paths: Verify all error conditions handled correctly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
