acassis commented on PR #18277: URL: https://github.com/apache/nuttx/pull/18277#issuecomment-3825352052
> > > > > > @W-M-R please update the Documentation: https://nuttx.apache.org/docs/latest/reference/user/07_signals.html > > > > > > > > > > > > > > > @acassis this patch doesn't add/remove nuttx signal api, why do you request @W-M-R update document. > > > > > > > > > > > > @xiaoxiang781216 the idea is to keep the signal documentation updated and since he is working on signal, this is the right moment to do it: > > > > <img alt="image" width="550" height="359" src="https://private-user-images.githubusercontent.com/37000/542846099-6aa07cda-13c8-40d9-bac5-67c15ecc1263.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njk3Nzc5NDMsIm5iZiI6MTc2OTc3NzY0MywicGF0aCI6Ii8zNzAwMC81NDI4NDYwOTktNmFhMDdjZGEtMTNjOC00MGQ5LWJhYzUtNjdjMTVlY2MxMjYzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTMwVDEyNTQwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRmNWJlNWUzZmM1MzFiZGM5NDMzZDMwMTcyMGRlM2QzMjQzZjI2NDViMDIzYmZmY2FmODlhNjM3NWMzMDFkMjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._crBGJ07Ww_PdWJjrKwmaPJLThNJxzAe5x62AWpTmds";> > > > > > > > > > here is https://nuttx.apache.org/docs/latest/reference/user/07_signals.html#c.sigdelset > > > > > > But and the remaining signals that should be in that table? > > CONFIG_SIG_SIGPIPE_ACTION CONFIG_SIG_SIGPROF_ACTION CONFIG_SIG_SIGURG_ACTION etc > > Please take a look here: sched/signal/sig_default.c > > This pr doesn't touch sig_default.c, so the update shouldn't belong to this pr. @acassis if you find something miss, please provide a patch to fix it, it doesn't make sense to ask contributor to update the doc which doesn't make related modification. Ok, yes I can dismiss the Change Request, but the point is: our Documentation is outdated, so everything someone is working is some relative feature that needs to be improved, we need to use request it. Even the file sig_default.c is not modified, the person modifying signals is the authority, they know more about signals than someone working on other features. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
![https://private-user-images.githubusercontent.com/37000/542846099-6aa07cda-13c8-40d9-bac5-67c15ecc1263.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njk3Nzc5NDMsIm5iZiI6MTc2OTc3NzY0MywicGF0aCI6Ii8zNzAwMC81NDI4NDYwOTktNmFhMDdjZGEtMTNjOC00MGQ5LWJhYzUtNjdjMTVlY2MxMjYzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTMwVDEyNTQwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRmNWJlNWUzZmM1MzFiZGM5NDMzZDMwMTcyMGRlM2QzMjQzZjI2NDViMDIzYmZmY2FmODlhNjM3NWMzMDFkMjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._crBGJ07Ww_PdWJjrKwmaPJLThNJxzAe5x62AWpTmds"](https://private-user-images.githubusercontent.com/37000/542846099-6aa07cda-13c8-40d9-bac5-67c15ecc1263.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Njk3Nzc5NDMsIm5iZiI6MTc2OTc3NzY0MywicGF0aCI6Ii8zNzAwMC81NDI4NDYwOTktNmFhMDdjZGEtMTNjOC00MGQ5LWJhYzUtNjdjMTVlY2MxMjYzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNjAxMzAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjYwMTMwVDEyNTQwM1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRmNWJlNWUzZmM1MzFiZGM5NDMzZDMwMTcyMGRlM2QzMjQzZjI2NDViMDIzYmZmY2FmODlhNjM3NWMzMDFkMjYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0._crBGJ07Ww_PdWJjrKwmaPJLThNJxzAe5x62AWpTmds"){kind=link}