xiaoxiang781216 commented on code in PR #18303:
URL: https://github.com/apache/nuttx/pull/18303#discussion_r2752338968
##########
arch/x86/src/i486/i486_utils.S:
##########
@@ -57,16 +57,16 @@
.type gdt_flush, @function
gdt_flush:
- movl %eax, 4(%esp) /* Get the pointer to the GDT, passed as a
parameter */
+ movl 4(%esp), %eax /* Get the pointer to the GDT, passed
as a parameter */
lgdt (%eax) /* Load the new GDT pointer */
- mov $KSEG, %ax /* KSEG is the offset in the
GDT to our data segment */
- mov %ax, %ds /* Load all data segment
selectors */
- mov %ax, %es
- mov %ax, %fs
- mov %ax, %gs
- mov %ax, %ss
- jmp $0x08, $.Lgflush /* 0x08 is the offset to our
code segment: Far jump! */
+ mov $KSEG, %ax /* KSEG is the offset in the GDT to our
data segment */
Review Comment:
why change the following lines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]