xiaoxiang781216 commented on code in PR #18300:
URL: https://github.com/apache/nuttx/pull/18300#discussion_r2752356727
##########
arch/arm/src/stm32h7/stm32_fdcan_sock.c:
##########
@@ -1420,7 +1429,7 @@ static int fdcan_interrupt(int irq, void *context,
if (irq == priv->config->mb_irq[0])
{
- fdcan_receive(priv);
+ fdcan_receive(priv);
Review Comment:
why change
##########
arch/arm/src/stm32h7/stm32_fdcan_sock.c:
##########
@@ -1276,6 +1279,12 @@ static void fdcan_receive_work(void *arg)
static void fdcan_txdone(struct fdcan_driver_s *priv)
{
+ /* DEBUG
+ * printf("[vmay] TXDONE: IR=0x%lx RXF0S=0x%lx\n",
Review Comment:
remove the comment?
##########
arch/arm/src/stm32h7/stm32_fdcan_sock.c:
##########
@@ -2042,6 +2051,11 @@ int fdcan_initialize(struct fdcan_driver_s *priv)
irqstate_t flags = enter_critical_section();
+ /* DEBUG
Review Comment:
ditto
##########
arch/arm/src/stm32h7/stm32_fdcan_sock.c:
##########
@@ -2320,6 +2356,14 @@ int fdcan_initialize(struct fdcan_driver_s *priv)
fdcan_dumpregs(priv);
#endif
+ /* Debug
Review Comment:
ditto
##########
arch/arm/src/stm32h7/stm32_fdcan_sock.c:
##########
@@ -2284,7 +2306,21 @@ int fdcan_initialize(struct fdcan_driver_s *priv)
regval = (ram_offset << FDCAN_RXF0C_F0SA_SHIFT) & FDCAN_RXF0C_F0SA_MASK;
regval |= (NUM_RX_FIFO0 << FDCAN_RXF0C_F0S_SHIFT) & FDCAN_RXF0C_F0S_MASK;
+
+ /* DEBUG
+ * printf("[vmay] NUM_RX_FIFO0=%d SHIFT=%d MASK=0x%lx\n",
+ * NUM_RX_FIFO0, FDCAN_RXF0C_F0S_SHIFT, FDCAN_RXF0C_F0S_MASK);
+ */
+
putreg32(regval, priv->base + STM32_FDCAN_RXF0C_OFFSET);
+
+ /* DEBUG
Review Comment:
ditto
##########
arch/arm/src/stm32h7/stm32_fdcan_sock.c:
##########
@@ -2284,7 +2306,21 @@ int fdcan_initialize(struct fdcan_driver_s *priv)
regval = (ram_offset << FDCAN_RXF0C_F0SA_SHIFT) & FDCAN_RXF0C_F0SA_MASK;
regval |= (NUM_RX_FIFO0 << FDCAN_RXF0C_F0S_SHIFT) & FDCAN_RXF0C_F0S_MASK;
+
+ /* DEBUG
+ * printf("[vmay] NUM_RX_FIFO0=%d SHIFT=%d MASK=0x%lx\n",
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
