anchao commented on code in PR #18284:
URL: https://github.com/apache/nuttx/pull/18284#discussion_r2753425871
##########
sched/clock/clock_sched_ticks.c:
##########
@@ -62,13 +64,13 @@ static volatile clock_t g_system_ticks =
INITIAL_SYSTEM_TIMER_TICKS;
void clock_increase_sched_ticks(clock_t ticks)
{
+ irqstate_t flags;
+
/* Increment the per-tick scheduler counter */
-#ifdef CONFIG_SYSTEM_TIME64
- atomic64_fetch_add((FAR atomic64_t *)&g_system_ticks, ticks);
-#else
- atomic_fetch_add((FAR atomic_t *)&g_system_ticks, ticks);
-#endif
+ flags = write_seqlock_irqsave(&g_system_tick_lock);
Review Comment:
>> 1 My submission https://github.com/apache/nuttx/pull/15414 did not
introduce a new issue; it merely had an oversight.
But you attempted an atomic optimization in #15414, so atomic64 didn't take
effect in your changes, did it? Didn't you check the generated instructions
after making the modifications?
**g_system_ticks** is only updated in the interrupt context, so:
a. This implementation works fine in AMP mode.
b. No issues arise on 64-bit hardware in SMP mode.
right?
Therefore, your commit needs to add a conditional check for SMP with 32-bit
hardware.
Because the current implementation is more streamlined on AMP and 64bit SMP
device.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
