linguini1 commented on code in PR #17977: URL: https://github.com/apache/nuttx/pull/17977#discussion_r2766242595
########## arch/arm64/src/bcm2711/bcm2711_serial.c: ########## @@ -568,7 +568,9 @@ static int bcm2711_miniuart_attach(struct uart_dev_s *dev) /* Set interrupt priority in GICv2 */ +#ifdef CONFIG_ARCH_IRQPRIO Review Comment: After encountering a compilation issue with this, I think: 1) This should be a guard around every instance of the function call, not just in these two files (sdio fails build) 2) `CONFIG_ARCH_IRQPRIO` should be defined for arm64 as a whole. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
