arjav1528 opened a new pull request, #3402: URL: https://github.com/apache/nuttx-apps/pull/3402
## Summary GitHub changed how source code archives for tags are served. The previous URL format for downloading a release tarball (e.g. `https://github.com/DaveGamble/cJSON/archive/v1.7.10.tar.gz`) no longer works; GitHub now requires `refs/tags/` in the path for tag-based archive downloads. This change updates the cJSON download URL in both the Makefile and CMakeLists.txt build paths to use the correct format: `.../archive/refs/tags/v${VERSION}.tar.gz`. Without this, the cJSON tarball download fails during the apps build when the source is fetched from GitHub. References: - [GitHub: Downloading source code archives](https://docs.github.com/en/repositories/working-with-files/using-files/downloading-source-code-archives) ## Impact - **Users**: Builds that fetch cJSON from GitHub (when the local cJSON tree is not present) will succeed instead of failing on the download step. - **Build process**: No change to build options or defaults; only the URL used for downloading the cJSON tarball is updated. Both Makefile and CMake build systems are updated. - **Compatibility**: Same cJSON version (e.g. 1.7.10) is downloaded; only the URL path is different. No API or behavioral change. ## Testing - **Host**: [e.g. macOS / Linux, CPU, compiler] - **Build**: Configured NuttX with `CONFIG_NETUTILS_CJSON=y`, cleaned the cJSON source directory and tarball, then ran the apps build to trigger download and build of cJSON. - **Result**: cJSON tarball downloaded successfully from the updated URL and the netutils/cjson application built without errors. - **Verification**: Build and runtime of a config that uses cJSON (e.g. a board that enables cJSON) to confirm no regressions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
