patacongo commented on a change in pull request #1661:
URL: https://github.com/apache/incubator-nuttx/pull/1661#discussion_r479586187



##########
File path: include/netpacket/bluetooth.h
##########
@@ -286,6 +271,13 @@ struct sockaddr_bt_s
   uint8_t      bt_channel; /* Channel identifier (CID) */
 };
 
+struct sockaddr_hci_s
+{
+  sa_family_t hci_family;
+  uint8_t     hci_dev;
+  uint8_t     hci_channel;
+};
+

Review comment:
       The HCI address structure is basically the same as Linux (struct 
sockaddr_hci):
   
   
https://elixir.bootlin.com/linux/latest/source/include/net/bluetooth/hci_sock.h#L37
   
   But not the L2CAP address (struct sockaddr_l2):
   
   
https://elixir.bootlin.com/linux/latest/source/include/net/bluetooth/l2cap.h#L65
   
   Does this matter?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to