xiaoxiang781216 commented on code in PR #17011: URL: https://github.com/apache/nuttx/pull/17011#discussion_r2802003711
########## drivers/timers/arch_timer.c: ########## Review Comment: the default value change to -1, which may hang the board which make call delay API before up_timer_set_lowerhalf is called ########## drivers/timers/arch_alarm.c: ########## @@ -36,6 +36,11 @@ * Pre-processor Definitions ****************************************************************************/ +/* If no value is given, we proceed with 0 since a one-shot timer is used for + * accurate delays. A runtime DEBUGASSERT catches the case where the one-shot + * timer lower-half isn't registered in time. + */ + #ifndef CONFIG_BOARD_LOOPSPERMSEC Review Comment: remove, it's impossible to undefine CONFIG_BOARD_LOOPSPERMSEC now with https://github.com/apache/nuttx/pull/17011/changes#diff-a37d53d5cfac3b7936a8b8458ce95450160808f4ae94c32ed60ac99809b95c45R1368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
