xiaoxiang781216 commented on code in PR #3404: URL: https://github.com/apache/nuttx-apps/pull/3404#discussion_r2844323770
########## system/ping6/ping6.c: ########## @@ -52,19 +53,6 @@ * Private Types ****************************************************************************/ -struct ping6_priv_s Review Comment: why move internal strut to header file ########## system/ping6/ping6.c: ########## @@ -109,10 +97,11 @@ static void show_usage(FAR const char *progname, int exitcode) * Name: ping_result ****************************************************************************/ -static void ping6_result(FAR const struct ping6_result_s *result) +void ping6_result(FAR const struct ping_result_s *result) Review Comment: why change to public function ########## include/netutils/icmpv6_ping.h: ########## @@ -66,53 +66,8 @@ * Public Types ****************************************************************************/ -struct ping6_result_s; - -struct ping6_info_s Review Comment: please move the reorg change to new pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
