linguini1 commented on PR #3413:
URL: https://github.com/apache/nuttx-apps/pull/3413#issuecomment-3954581490
> @linguini1 there are few places here BOARDIOC_INIT is used:
>
> ```
> $ git grep "BOARDIOC_INIT"
> boot/miniboot/miniboot_main.c: boardctl(BOARDIOC_INIT, 0);
> boot/nxboot/nxboot_main.c: boardctl(BOARDIOC_INIT, 0);
> examples/foc/foc_main.c: boardctl(BOARDIOC_INIT, 0);
> examples/lvgldemo/lvgldemo.c: boardctl(BOARDIOC_INIT, 0);
> examples/lvglterm/lvglterm.c: boardctl(BOARDIOC_INIT, 0);
> examples/nimble/nimble_main.c: boardctl(BOARDIOC_INIT, 0);
> examples/nimble_blecent/nimble_blecent_main.c: boardctl(BOARDIOC_INIT, 0);
> examples/nimble_bleprph/nimble_bleprph_main.c: boardctl(BOARDIOC_INIT, 0);
> examples/nxscope/nxscope_main.c: boardctl(BOARDIOC_INIT, 0);
> examples/powerled/powerled_main.c: boardctl(BOARDIOC_INIT, 0);
> examples/smps/smps_main.c: boardctl(BOARDIOC_INIT, 0);
> graphics/nxwidgets/ChangeLog.txt:* In NxWM unit test, call
boardctl(BOARDIOC_INIT) if available and
> graphics/nxwidgets/ReleaseNotes.txt:* In NxWM unit test, call
boardctl(BOARDIOC_INIT) if available and
> graphics/nxwm/ChangeLog.txt:* In NxWM unit test, call
boardctl(BOARDIOC_INIT) if available and
> graphics/nxwm/ReleaseNotes.txt:* In NxWM unit test, call
boardctl(BOARDIOC_INIT) if available and
> graphics/nxwm/src/nxwm_main.cxx: boardctl(BOARDIOC_INIT, 0);
> graphics/twm4nx/src/twm4nx_main.cxx: ret = boardctl(BOARDIOC_INIT, 0);
> graphics/twm4nx/src/twm4nx_main.cxx: twmerr("ERROR:
boardctl(BOARDIOC_INIT) failed: %d\n", errno);
> nshlib/nsh.h:/* Architecture-specific initialization depends on
boardctl(BOARDIOC_INIT) */
> nshlib/nsh_init.c: boardctl(BOARDIOC_INIT, 0);
> system/adb/adb_main.c: boardctl(BOARDIOC_INIT, 0);
> system/adcscope/adcscope_main.c: boardctl(BOARDIOC_INIT, 0);
> system/ofloader/ofloader.c: boardctl(BOARDIOC_INIT, 0);
> system/sensorscope/sensorscope_main.c: boardctl(BOARDIOC_INIT, 0);
> ```
>
> I think it is important to test it before we merge the simplified boot
init. I can test some of these, like twm4nx and nxwm, but we will need help
from each author to test the remaining.
> ie.: foc/nxscope/smps -> @raiden00pl; nxwidgets/nxwm/twm4nx -> @acassis;
ofloader -> @anjiahao1 (I can test it too because there is a board profile to
stm32f429i-disco that I have here)
>
Hi Alan,
You're right about the testing, but that will be part of the PR which
simplifies initialization. I will be testing it more thoroughly once I can get
the kernel PR to pass. This PR is just to add a header file and it solves a
compilation bug. It will allow the CI in my other PR to pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
