linguini1 commented on code in PR #3405:
URL: https://github.com/apache/nuttx-apps/pull/3405#discussion_r2849759779
##########
system/adb/Kconfig:
##########
@@ -200,19 +200,12 @@ config ADBD_SOCKET_SERVICE
---help---
Enable "adb forward|reverse" feature.
-config ADBD_BOARD_INIT
- bool "Board initialization"
- depends on BOARDCTL
- default n
- ---help---
- Setup board before running adb daemon.
-
config ADBD_USB_BOARDCTL
bool "USB Board Control"
depends on BOARDCTL
depends on ADBD_USB_SERVER
select BOARDCTL_USBDEVCTRL
- default ADBD_BOARD_INIT
+ default y
Review Comment:
Since this change removes BOARDIOC_INIT, the ADBD_BOARD_INIT doesn't do
anything anymore (it's removed). I changed the option to `y` because NSH
typically initializes the USB device stuff. Now that board_late_initialize will
be doing initialization by default, USB device things should be performed by
the app.
I'm not sure if it would be better to have opt-in behaviour instead (default
`n`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
