v01d commented on a change in pull request #1662:
URL: https://github.com/apache/incubator-nuttx/pull/1662#discussion_r479779665



##########
File path: arch/arm/src/nrf52/nrf52_gpiote.c
##########
@@ -183,7 +168,9 @@ int nrf52_gpiosetevent(uint32_t pinset, bool risingedge, 
bool fallingedge,
   int        ret    = OK;
   int        i      = 0;
   int        pin    = 0;
+#ifdef CONFIG_ARCH_CHIP_NRF52840

Review comment:
       I've seen your other PR relating to this. It should be then changed to a 
HAVE_* ifdef I guess then. I can merge your PR first and then adapt this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to