Abhishekmishra2808 commented on code in PR #18396: URL: https://github.com/apache/nuttx/pull/18396#discussion_r2886155022
########## tools/test_mkpasswd.c: ########## Review Comment: The intention of `test_mkpasswd.c ` was to verify the correctness of the TEA encryption and the password encoding pipeline with deterministic test vectors (round-trip tests, known hashes, boundary lengths, and key variations). Since mkpasswd is a small standalone host tool and the core logic is self-contained, I wanted to ensure the algorithm behaved exactly as expected before integrating it into the build process. However, you're correct that because the implementation logic is duplicated here, changes to mkpasswd.c would not necessarily be caught by this test. The original goal was algorithm validation rather than regression testing of the CLI tool itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
