resyfer commented on code in PR #18499: URL: https://github.com/apache/nuttx/pull/18499#discussion_r2891480872
########## boards/arm64/bcm2711/raspberrypi-4b/src/rpi4b_gpio.c: ########## @@ -46,13 +46,12 @@ * Pre-processor Definitions ****************************************************************************/ -/* Input pins */ +/** + * While BCM2711 has 58 GPIO pins, the RPi 4b's 40 pin header only has the + * GPIO pins in bank 1 (ie. GPIO pin 0 to 27). + */ -#define GPIO_IN1 16 - -/* Output pins */ - -#define GPIO_OUT1 26 +#define RPI4B_NGPIO 28 // 0-27 Review Comment: Hmmm, I actually don't properly get the reason for keeping the NGPIOOUT and NGPIOIN macros. 1. They are not used in the userspace. 2. They are not used in my changes anymore. 3. The `N` in that will cause a major headache to calculate at runtime as in this case users can select the number of GPIO pins they want. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
