mzanders commented on code in PR #18501:
URL: https://github.com/apache/nuttx/pull/18501#discussion_r2904642615
##########
arch/arm64/src/imx9/imx9_usdhc.c:
##########
@@ -1897,13 +1917,15 @@ static void imx9_clock(struct sdio_dev_s *dev, enum
sdio_clock_e rate)
{
struct imx9_dev_s *priv = (struct imx9_dev_s *)dev;
uint32_t regval;
+#ifndef CONFIG_IMX9_CLK_OVER_SCMI
unsigned speed;
+#endif
/* Clear the old prescaler and divisor values so that new ones can be
* ORed in.
*/
- regval = getreg32(priv->addr + IMX9_USDHC_SYSCTL_OFFSET);
+ regval = getreg32(priv->addr + IMX9_USDHC_SYSCTL_OFFSET);
Review Comment:
alignment change on purpose?
##########
arch/arm64/src/imx9/CMakeLists.txt:
##########
Review Comment:
Same change required on Make.defs?
##########
arch/arm64/src/imx9/CMakeLists.txt:
##########
@@ -24,7 +24,9 @@ set(SRCS imx9_boot.c imx9_clockconfig.c imx9_iomuxc.c
imx9_lpuart.c
imx9_lowputc.c)
if(CONFIG_ARCH_CHIP_IMX93)
- list(APPEND SRCS imx9_ccm.c imx9_gpio.c)
+ list(APPEND SRCS imx9_ccm.c imx9_gpio.c imx9_gpiobase.c)
Review Comment:
imx9_gpiobase.c is included in imx9_gpio.c!
I don't like it either, but adding it here should give issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
