mzanders commented on code in PR #18517: URL: https://github.com/apache/nuttx/pull/18517#discussion_r2905702500
########## sched/group/group_leave.c: ########## @@ -238,7 +238,8 @@ void group_drop(FAR struct task_group_s *group) /* Finally, if no one needs the group and it has been deleted, remove it */ - if (group->tg_flags & GROUP_FLAG_DELETED) + if ((group->tg_flags & GROUP_FLAG_DELETED) && Review Comment: That was my first idea too. But g_kthread_group is defined static in another translation unit. I think it should remain that way and we should respect the limited scope. Also, in the future there might be more static groups. The data should define the behavior, not which instance it is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
