acassis commented on issue #17051:
URL: https://github.com/apache/nuttx/issues/17051#issuecomment-4056903303

   @arjav1528 I don't know if I'm the right person to review it, since I don't 
have experience with these jinja2,etc.
   
   BTW, I took a look and found something I want you to double check:
   
   ```
           if args.report_missing and missing_help:
               print("CONFIG symbols without ---help--- text:", file=sys.stderr)
               for name in sorted(missing_help):
                   print(f"  {name}", file=sys.stderr)
               print(
                   f"\nTotal: {len(missing_help)} symbols",
                   file=sys.stderr,
               )
   ```
   
   Some CONFIG_ are used only as flag to indicate some feature as enable by 
other config, ex: STM_ADC, STM_SDADC, STM_DAC, ..., STM32_PWM
   
   So, you can report missing log only when doesn't have visible text:
   
   ```
   config STM32_ADC
           bool
           default n
   ```
   
   Normally they are "bool" without text, but I think it could exist other 
types too.
   
   Also if it is a "choice" it doesn't have help:
   
   ```
   choice 
           prompt "STM32 Chip Selection"
           default ARCH_CHIP_STM32F103ZE
           depends on ARCH_CHIP_STM32
   ```
   
   @simbit18 @lupyuen @linguini1 please take a look too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to