patacongo opened a new pull request #1682:
URL: https://github.com/apache/incubator-nuttx/pull/1682
## Summary
PR #1450 broke the Cygwin build. Refer to Issue #1672.
The use of of logic like:
EXTRA_LIBPATHS += -L "${dir ${shell $(CC) $(ARCHCPUFLAGS)
--print-file-name=libgcc.a}}"
fails when the Toolchain $(CC) is a native Windows toolchain. That is
because the returned path is a Windows-style patch which cannot be handled by
the make 'dir' command. Commit 4910d43ab0fc360dbddb1f8a31db2a3ee383b46d
reorganized a lot of definitions and replaced the correct code with the use of
the limit make 'dir' command. The original code used the Bash dirname command
which does not suffer from this limitation; it can handle both POSIX and
Windows paths.
## Impact
This could potential effect all builds but I expect that the only effect is
that it will make the Cygwin builds usable again.
## Testing
This was verified using the stm32f4discover:nsh toolchain with the Windows
native ARM Embedded toolchain. That toolchain returns:
arm-none-eabi-gcc --print-file-name=libgcc.a
c:/program files (x86)/gnu tools arm embedded/9
2019-q4-major/bin/../lib/gcc/arm-none-eabi/9.2.1/libgcc.a
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
