Copilot commented on code in PR #18841: URL: https://github.com/apache/nuttx/pull/18841#discussion_r3177847625
########## fs/spiffs/src/spiffs.h: ########## @@ -122,11 +122,7 @@ struct spiffs_s FAR uint8_t *work; /* Secondary work buffer, size of a logical page */ FAR uint8_t *mtd_work; /* MTD I/O buffer for read-modify-write */ FAR void *cache; /* Cache memory */ -#ifdef CONFIG_HAVE_LONG_LONG off64_t media_size; /* Physical size of the SPI flash */ Review Comment: `media_size` is now typed as `off64_t` unconditionally, but `off64_t` is only defined in `include/sys/types.h` when `CONFIG_FS_LARGEFILE` is enabled. This will break builds with SPIFFS enabled but `CONFIG_FS_LARGEFILE` disabled (unknown type `off64_t`). Use `off_t` here, or make the type conditional on `CONFIG_FS_LARGEFILE` instead of long long support. ########## libs/libc/libc.csv: ########## @@ -320,10 +316,10 @@ "strtok","string.h","","FAR char *","FAR char *","FAR const char *" "strtok_r","string.h","","FAR char *","FAR char *","FAR const char *","FAR char **" "strtol","stdlib.h","","long","FAR const char *","FAR char **","int" -"strtoll","stdlib.h","defined(CONFIG_HAVE_LONG_LONG)","long long","FAR const char *","FAR char **","int" +"strtoll","stdlib.h","","long long","FAR const char *","FAR char **","int" "strtoul","stdlib.h","","unsigned long","FAR const char *","FAR char **","int" "strtoull","stdlib.h","","unsigned long long int","FAR const char *","FAR char **","int" -"strtoull","stdlib.h","defined(CONFIG_HAVE_LONG_LONG)","unsigned long long","FAR const char *","FAR char **","int" +"strtoull","stdlib.h","","unsigned long long","FAR const char *","FAR char **","int" Review Comment: `libc.csv` now contains two unconditional entries for `strtoull` (lines 321-322) with equivalent return types (`unsigned long long int` vs `unsigned long long`). With `CONFIG_HAVE_LONG_LONG` removed, one of these should be dropped to avoid duplicate symbol rows in the libc API list/generation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
