xiaoxiang781216 commented on PR #18840: URL: https://github.com/apache/nuttx/pull/18840#issuecomment-4366548038
> @xiaoxiang781216 this kind of broad change needs to be discussed before in the mailing list because it affect all architectures. Just to highlight some concerning points: > already discuss before in email thread: https://github.com/apache/nuttx/pull/14460 > 1. This kind of modification cannot be merged without been tested in all architectures, "tools/checkpatch.sh -f" is not a valid testing; add the test and log > 2. Increasing the system time to 64-bit could have size impact, please provide this value for small boards (like AVR8 or a STM32 chip with few KB of RAM like, stm32vldiscovery is a good candidate) > 3. Instead removing it, better to enable it by default, except for DEFAULT_SMALL 64bit time_t is required by POSIX spec, it can't be an option anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
