acassis commented on PR #18843:
URL: https://github.com/apache/nuttx/pull/18843#issuecomment-4372338463
> > Yes, unfortunately the RFC is ambiguous, it only said that I need to
discard a packet with optlen 0. Fortunately my solution already fixes it
because I do a "goto icmpv6_drop_packet" that will exit the entire loop.
>
> Before drop, `neighbor_add(dev, ipv6->srcipaddr, sllopt->srclladdr);` the
neighbor is added, but we don't need this effect.
Hmm, you are right, I think I should change the generic option header first,
I will add this check:
```
if (scan + sizeof(struct icmpv6_generic_s) > optlen)
{
goto icmpv6_drop_packet;
}
```
Do you see any other issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
