ghnotgood commented on PR #18853:
URL: https://github.com/apache/nuttx/pull/18853#issuecomment-4389209703
> @ghnotgood please fix:
>
> ```
> Error:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/kinetis/kinetis_oneshot_pit.c:1:78:
error: Block comments have different lengths
> Error:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/kinetis/kinetis_oneshot_pit.c:21:77:
error: Block comments have different lengths
> Warning:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/kinetis/kinetis_oneshot_pit.c:35:1:
warning: #include outside of 'Included Files' section
> Warning:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/kinetis/kinetis_oneshot_pit.c:37:1:
warning: #include outside of 'Included Files' section
> Warning:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/kinetis/kinetis_oneshot_pit.c:38:1:
warning: #include outside of 'Included Files' section
> Warning:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/kinetis/kinetis_oneshot_pit.c:40:1:
warning: #include outside of 'Included Files' section
> Warning:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/kinetis/kinetis_oneshot_pit.c:41:1:
warning: #include outside of 'Included Files' section
> Warning:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/kinetis/kinetis_oneshot_pit.c:43:1:
warning: #include outside of 'Included Files' section
> Warning:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/kinetis/kinetis_oneshot_pit.c:44:1:
warning: #include outside of 'Included Files' section
> Warning:
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/kinetis/kinetis_oneshot_pit.c:46:1:
warning: #include outside of 'Included Files' section
>
/home/runner/work/nuttx/nuttx/nuttx/arch/arm/src/kinetis/kinetis_oneshot_pit.c:59:
implementaiton ==> implementation
> ```
I have added `Included Files` section and fixed typo. Thanks.
I have a question about the `Block comments have different lengths` error,
though. It looks like that the last line of the block comment check in
`block_comment_width` procedure excludes the leading space, which forces the
first line of the block comment to be aligned to 77, not 78 (missing last `*`).
I think this should be fixed with
```
$ git diff
diff --git i/tools/nxstyle.c w/tools/nxstyle.c
index d464dc3fb0..e6196b8892 100644
--- i/tools/nxstyle.c
+++ w/tools/nxstyle.c
@@ -1050,7 +1050,7 @@ static int block_comment_width(char *line)
{
/* Return the length of the line up to the final '*' */
- return e;
+ return e + b;
}
/* But there is also a special single line comment that begins with
"[slash]* "
```
How should I proceed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
