hartmannathan commented on code in PR #3468: URL: https://github.com/apache/nuttx-apps/pull/3468#discussion_r3202148118
########## netutils/netinit/netinit.c: ########## @@ -204,11 +204,7 @@ * signal indicating a change in network status. */ -#ifdef CONFIG_SYSTEM_TIME64 -# define LONG_TIME_SEC (60*60) /* One hour in seconds */ -#else -# define LONG_TIME_SEC (5*60) /* Five minutes in seconds */ -#endif +#define LONG_TIME_SEC (60*60) /* One hour in seconds */ #define SHORT_TIME_SEC (2) /* 2 seconds */ Review Comment: ...and if we change LONG_TIME_SEC to ONE_HOUR_SEC, then SHORT_TIME_SEC should become something like TWO_SEC? ########## netutils/netinit/netinit.c: ########## @@ -204,11 +204,7 @@ * signal indicating a change in network status. */ -#ifdef CONFIG_SYSTEM_TIME64 -# define LONG_TIME_SEC (60*60) /* One hour in seconds */ -#else -# define LONG_TIME_SEC (5*60) /* Five minutes in seconds */ -#endif +#define LONG_TIME_SEC (60*60) /* One hour in seconds */ Review Comment: I suppose it would make more sense to call this ONE_HOUR_SEC, but that's a job for another PR :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
