cederom commented on PR #18832: URL: https://github.com/apache/nuttx/pull/18832#issuecomment-4407385460
> I think some things in the application space are fine, shim layers should stay in apps. For instance, downloading the Unity test framework repo but hooking in our own shim layer. This also gives us a nice (?) indication that we're making an impactful breaking change. Yes we talked about that before some times. We should stay as much self-contained as possible. If code can be small part of the nuttx-apps it should be part of the nuttx-apps. If dependency is large and not really part of the code (i.e. sdk tool, compiler, etc) it could be part of nuttx-deps repo :-) I proposed to put bigger dependencies, libraties, tools into a separate repo because: * Core nuttx and nuttx-apps repos would stay as minimal as possible. * That would solve us lots of problem with testing. * This would solidify the dependencies versions (i.e. rpi-pico-sdk used in different verions by different developers). * We could fetch all stuff, then go offline, perform tests in one-time-use environment for safety, and then export the results :-) * Not sure here yet how to implement it for every dependency (i.e. esp-idf/sdk) but we could try small steps approach :-) * We may use git submodule for really big dependencies? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
