linguini1 commented on PR #3474: URL: https://github.com/apache/nuttx-apps/pull/3474#issuecomment-4420296099
> Thanks for the review. > > I’ve updated the PR description to follow the template, added more detail about what `nxpkg` does, and included the runtime validation steps and target used for testing. > > I also pushed a small follow-up change to address the `fprintf` feedback and removed the temporary debug-only logging. > > For a bit of context, this PR is also part of my GSoC work, and I’m intentionally submitting it in smaller scoped pieces so the basic app-side `nxpkg` tool can be reviewed early, while the related board-side work and later features come in follow-up PRs. > > Please take another look when you get a chance. > Looks better! Just an FYI, the contributing guide states a "zero trust approach to testing". This means that you should include full log output from your tests, not just a verbal description of your steps (although that's good to include alongside the logs) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
