Copilot commented on code in PR #3481: URL: https://github.com/apache/nuttx-apps/pull/3481#discussion_r3238605614
########## testing/ltp/Makefile: ########## @@ -238,6 +238,7 @@ CFLAGS += -Wno-int-conversion -Wno-shadow # Should be removed if possible in the future CFLAGS += -Wno-incompatible-pointer-types -Wno-overflow -Wno-int-to-pointer-cast +CFLAGS += -Wno-shift-count-overflow Review Comment: Suppressing this warning masks the underlying invalid constant expression in the LTP header: when `time_t` is 64-bit but `unsigned long` is only 32-bit (the failing rv-virt case), `1UL << 63` has a shift count greater than or equal to the type width, so the computed `TIME_T_MAX` value is not reliable. Please patch the imported header or otherwise fix the macro instead of globally disabling this diagnostic, otherwise the suite can compile while tests use the wrong boundary value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
