xiaoxiang781216 commented on PR #3489: URL: https://github.com/apache/nuttx-apps/pull/3489#issuecomment-4487410813
> _Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md)._ > > ## Summary > This PR addresses the concrete `open()` argument issues reported in #1879: > > * `nshlib/nsh_script.c`: pass explicit open flags for the script redirect file, and keep `0666` as the creation mode. > * `testing/ostest/aio.c`: pass a mode argument for `open()` calls that use `O_CREAT`. > > I kept this PR scoped to the examples mentioned in the issue. While checking the tree, I also found other possible `open(..., O_CREAT, ...)` call sites that may need review, so maintainer guidance would be useful on whether to extend this PR or handle those separately. > > Refs #1879 @nightt5879 please modify the places which you found the similar issue in this pr too, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
