michallenc commented on code in PR #18904: URL: https://github.com/apache/nuttx/pull/18904#discussion_r3274044223
########## drivers/mtd/mx25rxx.c: ########## @@ -127,6 +128,14 @@ #define MX25R6435F_SECTOR_COUNT (2048) #define MX25R6435F_PAGE_SIZE (256) +/* MX25L12873G (128 MB) memory capacity */ Review Comment: I agree it's probably better to recalculate the size to (mega)bytes instead of using bits. My main point was that the current comment says the flash size is 128 megabytes (or technically mebibytes), but it's actually just 32. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
