xiaoxiang781216 commented on code in PR #3498: URL: https://github.com/apache/nuttx-apps/pull/3498#discussion_r3293938251
########## system/microros/patches/0003-rcutils-strcasecmp-include-strings-h.patch: ########## @@ -0,0 +1,18 @@ +From: micro-ROS NuttX Port <[email protected]> +Subject: [PATCH] rcutils: include <strings.h> for strcasecmp on POSIX systems + +POSIX specifies strcasecmp/strncasecmp in <strings.h>, not <string.h>. +On NuttX (and other strict POSIX environments) omitting this header +causes an "implicit declaration" error. Add the include guarded by +!_WIN32 to match the existing Windows/POSIX split in the file. + +--- a/rcutils/src/strcasecmp.c ++++ b/rcutils/src/strcasecmp.c +@@ -17,6 +17,9 @@ extern "C" + #include <errno.h> + #include <string.h> Review Comment: should we align with Linux? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
