acassis commented on PR #18950: URL: https://github.com/apache/nuttx/pull/18950#issuecomment-4564247592
> > @patrickelectric I'm not saying that no optimizations are enabled by default. I'm saying that no optimizations from libc/machine are enabled by default. Most of these features are licensed under the BSD license, so they should be protected by `CONFIG_ALLOW_BSD_COMPONENTS`. With your change generated code contains BSD by default, which may not be desired by the user > > That's a strong point. Well, I'm ok to close this PR so. > > Now, the next steps, document this performance impact! Can someone point me where to document this ? I'll 100% sure put in [tcp_network_perf](https://nuttx.apache.org/docs/latest/components/net/tcp_network_perf.html). Yes, I think documentation it there is important. Independent if this PR get merged or not. Because same issue could happen on other ARCH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
