Zepp-Hanzj commented on PR #19000: URL: https://github.com/apache/nuttx/pull/19000#issuecomment-4589373013
> Hello @Zepp-Hanzj, checkpatch, code review and pattern matching (while good) generally aren't sufficient testing. In this case, since the simulator doesn't require specific hardware, could you please perform a test to make sure this fixes the regression? > > The code does look fine though. My apologies for the oversight. I've since updated the PR with runtime verification on the simulator — directly testing the usrsock_ioctl_handler with crafted inputs covering all three boundary checks. All 4 test cases pass. I'll make sure to include proper verification upfront in future PRs. Thanks for the review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
