xiaoxiang781216 commented on PR #3511: URL: https://github.com/apache/nuttx-apps/pull/3511#issuecomment-4608816326
> @xiaoxiang781216 Rebased onto the latest master and force-pushed the branch. > > The conflict was resolved by keeping the upstream dpopen()/dpclose() implementation and the new testing/libc/popen test, then reapplying only the fopencookie() change in popen.c to avoid copying FILE. > > I re-tested with: > > * git diff --check upstream/master..HEAD > * checkpatch.sh -f ../apps/system/popen/popen.c > * sim:nsh build with CONFIG_SYSTEM_POPEN=y and CONFIG_TESTING_POPEN=y > * popen_test, which reports 0 failed Thanks, the new version is much simple now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
