jlaitine commented on code in PR #19018:
URL: https://github.com/apache/nuttx/pull/19018#discussion_r3347502448
##########
drivers/mtd/Kconfig:
##########
@@ -50,6 +50,15 @@ config FTL_READAHEAD
default n
depends on DRVR_READAHEAD
+config FTL_BBM
+ bool "Enable bad block management in the FTL layer"
+ default y if MTD_NAND
Review Comment:
I don't think DEFAULT_SMALL is the correct one here. All of the boards which
I am working on are !DEFAULT_SMALL and bad block management is not needed. Only
reasonable default that I can think of is really MTD_NAND, because BBM on the
host controller side is really commonly needed only for raw nand devices. If
the motivation behind the suggestion is that there are other than MTD_NAND
devices, where default y is wanted, please give an example of that... perhaps
we can add some additiona "default y if ..."?
In addition, we could have a DEFAULT_SMALL board using raw nand, in which
case the BBM would be needed.
So I'd rather find a reasonable default based on whether the functionality
is required or not, and not couple it to DEFAULT_SMALL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
