Zepp-Hanzj opened a new pull request, #3518:
URL: https://github.com/apache/nuttx-apps/pull/3518
## Summary
Fixes #11435
`SYSTEM_POPEN` currently uses `depends on PIPES`, requiring users to
manually enable the pipe driver before popen becomes visible. Since `popen()`
fundamentally requires pipes to function, it should `select PIPES`
automatically — matching the pattern already used by `gs2200m`, `alt1250`,
`usrsocktest`, and `lely-canopen`.
## Change
```diff
config SYSTEM_POPEN
bool "popen()/pclose() Functions"
default n
select SCHED_WAITPID
- depends on NSH_LIBRARY && PIPES
+ depends on NSH_LIBRARY
+ select PIPES
```
## Testing
Verified on `sim:nsh` with CMake build:
1. **Default config** (`PIPES=y`, `SYSTEM_POPEN` unset) — compiles normally ✅
2. **Manual disable PIPES + enable SYSTEM_POPEN** — `olddefconfig`
automatically re-enables `CONFIG_PIPES=y` ✅
3. **Build with popen enabled** — compiles successfully ✅
4. **Runtime** — ran `popen` example, `popen("help")` executed and returned
shell output correctly ✅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
