aviralgarg05 opened a new pull request, #3519:
URL: https://github.com/apache/nuttx-apps/pull/3519

   ## Summary
   
   This change fills in missing module metadata for a small set of executable 
tools that are already selectable from `apps/`, but were still treated as 
builtin-only in their Kconfig or Makefile paths.
   
   Concretely, it:
   - adds missing `MODULE` assignments for the affected executables
   - switches a few command/demo Kconfig entries from `bool` to `tristate` 
where module-capable builds need that distinction
   - updates the matching Makefile conditionals from `ifeq(...,y)` to 
`ifneq(...,)` where the build should accept either builtin or module selection
   
   The affected commands are limited to existing executable entry points in:
   - `crypto/libtomcrypt`
   - `crypto/tinycrypt`
   - `database/sqlite`
   - `logging/embedlog`
   - `math/libtommath`
   - `system/fdt`
   - `system/libuv`
   - `videoutils/x264`
   
   ## Impact
   
   This makes the affected tools participate correctly in module-capable builds 
instead of silently behaving as builtin-only selections.
   
   There is no intended functional change for configurations that continue to 
build these commands in the normal builtin path.
   
   This patch does not change board logic, runtime loader behavior, or 
package-management behavior. It is limited to `apps/` Kconfig and Makefile 
metadata.
   
   ## Testing
   
   Host:
   - macOS 26.5
   - Apple Silicon (`arm64`)
   - `xtensa-esp-elf-gcc (crosstool-NG esp-14.2.0_20241119) 14.2.0`
   - `esptool.py v4.11.0`
   
   Target used for verification:
   - `xtensa`
   - `esp32s3-xiao:usbnsh`
   - clean detached `apache/nuttx` `master` worktree paired with this `apps` 
commit
   
   Build steps:
   ```sh
   ./tools/configure.sh -E -a ../apps-clean esp32s3-xiao:usbnsh
   make olddefconfig
   make -j8
   ```
   
   Build result:
   ```text
   LD: nuttx
   CP: nuttx.hex
   MKIMAGE: ESP32-S3 binary
   Generated: nuttx.bin
   ```
   
   This PR only adjusts `apps` module metadata, so no board-specific runtime 
behavior changed in this slice and no separate hardware runtime log was 
required.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to