xiaoxiang781216 commented on PR #19041: URL: https://github.com/apache/nuttx/pull/19041#issuecomment-4629816156
> > @parthitce your pr removes many functionality (cache, mpu, hwdebug, perf, setjmp/longjmp, tasking compiler), > > @xiaoxiang781216 Thanks for the quick review. > > Tasking: Regarding the tasking support, we should be enable them back. This was mainly because of missing licensed access to it. setjmp/longjmp: IMO we should be revert and use the existing `libs/libc/machine/tricore/arch_setjmp.c` , probably .S cache, mpu, hwdebug, perf: All of the existing implementation are dependent on iLLD. The main aim of this PR is to prepare working version of the TriCore Aurix without any dependency. So the followup series will add as independent implementation. Clubbing all in the first level PR will increase the size. > > > please organize your patch that any change to the origin code need split to the small but self-contained patch and describe the reason you make this change clearly. > > Currently commits are logically grouped. Let us know if this needs spliting. Yes, you need split the big patch into small one like this: 1. one patch just rename tc397 to tc3x, tc4da to tc4x, and ensure the build and boot still work 2. one path just move setjmp/longjmp from arch/tricore to libc/machine/tricore 3. one patch replace iLLD based MPU implementation by the register based one ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
