Shriyans406 commented on PR #18831: URL: https://github.com/apache/nuttx/pull/18831#issuecomment-4631035408
Thank you for the review 1. Yes, I have tested this and verified that the LED functions correctly. 2. I have updated the PR title to fix the truncation and accurately reflect the changes. 3. I also fixed the trailing blank lines checkpatch error, and the CI should pass now. Please let me know if there is anything else needed Regards On Wed, Jun 3, 2026 at 12:49 AM Matteo Golin ***@***.***> wrote: > *linguini1* left a comment (apache/nuttx#18831) > <https://github.com/apache/nuttx/pull/18831#issuecomment-4606230332> > > Did you actually test this on the board? Also please fix the PR title that > is truncated. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/nuttx/pull/18831?email_source=notifications&email_token=BMTFX7WSEBVOQSBULHTQT2T454SCRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRQGYZDGMBTGMZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4606230332>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/BMTFX7QZ5U4KJW3UI36HEWL454SCRAVCNFSM6AAAAACYOBZOHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DMMBWGIZTAMZTGI> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/BMTFX7SIWEV6KB44OFXT3XL454SCRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRQGYZDGMBTGMZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/BMTFX7XAVRBLSL53Z3I26YT454SCRA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINRQGYZDGMBTGMZKM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
