xiaoxiang781216 commented on code in PR #19113:
URL: https://github.com/apache/nuttx/pull/19113#discussion_r3390833987
##########
drivers/timers/arch_alarm.c:
##########
@@ -183,11 +183,15 @@ void weak_function up_mdelay(unsigned int milliseconds)
*
****************************************************************************/
+#ifndef CONFIG_ARCH_HAVE_UDELAY
+
void weak_function up_udelay(useconds_t microseconds)
Review Comment:
let's remove weak_function in all places
##########
sched/clock/clock_delay.c:
##########
@@ -67,8 +67,14 @@
"new value to apache/nuttx."
#endif
+#ifndef CONFIG_ARCH_HAVE_DYNAMIC_UDELAY
Review Comment:
let's make BOARD_LOOPSPERMSEC depends on !ARCH_HAVE_DYNAMIC_UDELAY
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
