ghaerr commented on issue #18566: URL: https://github.com/apache/nuttx/issues/18566#issuecomment-4697304189
Hello @Acfboy, Thank you for your very precise descriptions of various problems. Agreed something needs to be done regarding the `ERROR` symbol. This gets a bit complicated, because I think (but have not yet checked) that ERROR is actually defined by MSFT in their windows.h, which means it may not be a great idea to change it. This needs to be researched a bit for compatibility reasons, as obviously NuttX has the potentially the same idea about ERROR being important. [EDIT: Reading up a bit on all of this, it seems it's somewhat well-known that MSFT's ERROR macro in wingdi.h is problematic. Some sources recommend using \#define NOGDI to prevent wingdi.h from 1) being included at all in windows.h, and 2) preventing an ERROR macro from being defined]. What do you think about using using something like -DNOGDI or \#define NOGDI and just changing wingdi.h to prevent ERROR from being defined, and then used in NuttX source compilations? If you agree, I can quickly push this fix for you, which sounds like it'd solve your problem without any effect on the rest of the source tree. Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
