xiaoxiang781216 commented on code in PR #19116:
URL: https://github.com/apache/nuttx/pull/19116#discussion_r3408578016
##########
libs/libc/pthread/pthread_kill.c:
##########
@@ -61,7 +67,25 @@
int pthread_kill(pthread_t thread, int signo)
{
- int ret = tkill((pid_t)thread, signo);
+ int ret;
+
+#ifdef CONFIG_DISABLE_ALL_SIGNALS
+ struct sched_param param;
Review Comment:
let's modify nxsig_dispatch to skip group_signal/nxsig_tcbdispatch direclty
if info->si_signo equals 0
##########
syscall/syscall.csv:
##########
@@ -56,7 +56,6 @@
"inotify_rm_watch","sys/inotify.h","defined(CONFIG_FS_NOTIFY)","int","int","int"
"insmod","nuttx/module.h","defined(CONFIG_MODULE)","FAR void *","FAR const
char *","FAR const char *"
"ioctl","sys/ioctl.h","","int","int","int","...","unsigned long"
-"kill","signal.h","","int","pid_t","int"
Review Comment:
let's still keep kill as the syscall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
