jlaitine commented on PR #19018: URL: https://github.com/apache/nuttx/pull/19018#issuecomment-4708202962
For NAND devices the CONFIG_FTL_BBM is selected by default - these are the ones that typically would need it. If any other (non mtd nand) driver needs BBM, it can just select it in the respective Kconfig definition, to avoid misconfiguration. Part of the driver implementation is the config flag which enables it. Anyhow, compiling the image without CONFIG_FTL_BBM doesn't cause system crash, it will just cause the bad block management not being there in FTL layer (as this is what the flag does), that is, the framework just wouldn't call the markbad and isbad functions defined by the driver. I don't really see an issue here. Devices which need the BBM in the host software are not common, and those drivers which need it can just enable it by default. On 6/15/26 14:11, Michal Lenc wrote: > > ***@***.**** commented on this pull request. > > ------------------------------------------------------------------------ > > In drivers/mtd/Kconfig > <https://github.com/apache/nuttx/pull/19018#discussion_r3412984974>: > > > @@ -50,6 +50,15 @@ config FTL_READAHEAD > default n > depends on DRVR_READAHEAD > > +config FTL_BBM > + bool "Enable bad block management in the FTL layer" > + default y if MTD_NAND > > I am talking about the opposite scenario. MTD driver sets |markbad| > and |isbad|, but now you have to manually enable |CONFIG_FTL_BBM|, > otherwise you end up with the assertion. The option should be set > automatically if |CONFIG_MTD_PARTITION| is configured. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/nuttx/pull/19018?email_source=notifications&email_token=AFSLTVU5JHDJ6J3O4ETDHY3477KVBA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINBZGY4DANBQGU3KM4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#discussion_r3412984974>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFSLTVXGOWJ3Y67K2XMS6PT477KVBAVCNFSNUABFKJSXA33TNF2G64TZHMZDEOBRGAZTENZTHNEXG43VMU5TINJXGA2TIMBVGIZ2C5QC>. > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
