acassis commented on PR #3532: URL: https://github.com/apache/nuttx-apps/pull/3532#issuecomment-4708513802
> Good work getting it going! I suspect there are probably a few more cleanup edge cases that need dealing with, upstream Dropbear relies on exit() cleanup a fair bit. At least most of the postauth code should be in your own dropbear_nshsession.c to handle specially there. > > I've added a few notes about upstream parts. > > I don't think `UNUSED()` changes make sense to go upstream. It seems like it would be simpler to `#undef UNUSED` somewhere in an appropriate nuttx-dropbear header file? (Not sure where the NuttX definition comes from) Hi @mkj thank you very much for your review and suggestions. I think undefining UNUSED macro and defining it again could work, but could we agree at least in moving the UNUSED from been used in the function prototype and move it to end of the function, like here: https://github.com/apache/nuttx/blob/master/drivers/syslog/syslog_channel.c#L304 This way works better for old compilers (that don't know about __attribute__((unused)) ), since NuttX is used for retro-computing as well (not only microcontrollers). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
